Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test cheat #11

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

QGarchery
Copy link
Contributor

This PR:

  • updates the munging patch to avoid having line offsets
  • removes the dynamic loading of code and uses vm.store and vm.load cheatcodes instead

@QGarchery QGarchery requested a review from MathisGD August 13, 2024 12:26
@QGarchery QGarchery self-assigned this Aug 13, 2024
@MathisGD
Copy link
Contributor

  • updates the munging patch to avoid having line offsets

curious how did you do this

@MathisGD MathisGD merged commit 16bf70f into feat/no-share-price-decrease-2 Aug 13, 2024
21 of 22 checks passed
@MathisGD MathisGD deleted the refactor/no-share-price branch August 13, 2024 12:55
@QGarchery
Copy link
Contributor Author

To update the munging, you can do:
make -C certora clean
make -C certora munged
At this step you need to be careful, because some hunks may not be used perfectly. Notably sometimes it leaves a file.orig that you need to remove
And then you do
make -C certora record and commit the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants