Xlint:all and code quality improvements,

autoconfig/src/main/java/es/urjc/etsii/grafo/autoconfig/exception/AlgorithmParsingException.java

@@ -1,7 +1,12 @@
 package es.urjc.etsii.grafo.autoconfig.exception;
 
+import java.io.Serial;
+
 public class AlgorithmParsingException extends RuntimeException {
 
+    @Serial
+    private static final long serialVersionUID = 1L;
+
     public AlgorithmParsingException(String message, Throwable cause) {
         super(message, cause);
     }

common/src/main/java/es/urjc/etsii/grafo/exception/IllegalAlgorithmConfigException.java

@@ -1,10 +1,15 @@
 package es.urjc.etsii.grafo.exception;
 
+import java.io.Serial;
+
 /**
  * Thrown by any algorithm component when the combination of parameters given is not valid
  */
 public class IllegalAlgorithmConfigException extends IllegalArgumentException {
 
+    @Serial
+    private static final long serialVersionUID = 1L;
+
     /**
      * Initialize the exception
      * @param explanation Explanation

common/src/main/java/es/urjc/etsii/grafo/exception/InstanceImportException.java

@@ -1,9 +1,14 @@
 package es.urjc.etsii.grafo.exception;
 
+import java.io.Serial;
+
 /**
  * Exception thrown when there is any problem loading an instance
  */
 public class InstanceImportException extends RuntimeException {
+    @Serial
+    private static final long serialVersionUID = 1L;
+
     public InstanceImportException(String message) {
         super(message);
     }

common/src/main/java/es/urjc/etsii/grafo/exception/InvalidRandomException.java

@@ -1,7 +1,11 @@
 package es.urjc.etsii.grafo.exception;
 
+import java.io.Serial;
+
 /**
  * Thrown when an invalid random usage is detected, which would affect experiment reproducibility, and suggests alternatives to use.
  */
 public class InvalidRandomException extends RuntimeException {
+    @Serial
+    private static final long serialVersionUID = 1L;
 }

common/src/main/java/es/urjc/etsii/grafo/exception/InvalidSolutionException.java

@@ -1,10 +1,15 @@
 package es.urjc.etsii.grafo.exception;
 
+import java.io.Serial;
+
 /**
  * Thrown if the solution is not valid at different solving stages
  */
 public class InvalidSolutionException extends RuntimeException {
 
+    @Serial
+    private static final long serialVersionUID = 1L;
+
     /**
      * Create a new InvalidSolutionException with the given reason
      * @param cause why the solution is not valid

common/src/main/java/es/urjc/etsii/grafo/exception/ResourceLimitException.java

@@ -1,12 +1,17 @@
 package es.urjc.etsii.grafo.exception;
 
+import java.io.Serial;
+
 /**
  * Thrown when the maximum allocated resources are consumed,
  * or when even if they are not consumed,
  * it is estimated with high confidence that we cannot complete the operation.
  */
 public class ResourceLimitException extends RuntimeException {
 
+    @Serial
+    private static final long serialVersionUID = 1L;
+
     /**
      * Initialize the exception
      * @param message Explanation

common/src/main/java/es/urjc/etsii/grafo/improve/Improver.java

@@ -74,6 +74,7 @@ public static <S extends Solution<S,I>, I extends Instance> Improver<S,I> nul(){
     }
 
     @SafeVarargs
+    @SuppressWarnings("varargs")
     public static <S extends Solution<S,I>, I extends Instance> Improver<S,I> serial(FMode fmode, Improver<S, I>... improvers){
         return new SequentialImprover<>(fmode, improvers);
     }
@@ -108,13 +109,14 @@ public static class SequentialImprover<S extends Solution<S,I>,I extends Instanc
         private final Improver<S,I>[] improvers;
 
         @SafeVarargs
+        @SuppressWarnings("varargs")
         public SequentialImprover(FMode fmode, Improver<S, I>... improvers) {
             super(fmode);
             this.improvers = improvers;
         }
 
         @AutoconfigConstructor
-        @SuppressWarnings("unchecked")
+        @SuppressWarnings({"unchecked", "rawtype"})
         public SequentialImprover(
                 @ProvidedParam FMode fmode,
                 Improver<S, I> improverA,

common/src/main/java/es/urjc/etsii/grafo/solution/neighborhood/Neighborhood.java

@@ -67,6 +67,7 @@ public String toString() {
      * @return a new neighborhood which returns the moves from each neighborhood as a sequence
      */
     @SafeVarargs
+    @SuppressWarnings("varargs")
     public static <M extends Move<S, I>, S extends Solution<S, I>, I extends Instance> Neighborhood<M, S, I> concat(Neighborhood<M, S, I>... neighborhoods) {
         return new ConcatNeighborhood<>(neighborhoods);
     }
@@ -81,6 +82,7 @@ public static <M extends Move<S, I>, S extends Solution<S, I>, I extends Instanc
      * @return a new neighborhood which returns the moves from each neighborhood alternating between them
      */
     @SafeVarargs
+    @SuppressWarnings("varargs")
     public static <M extends Move<S, I>, S extends Solution<S, I>, I extends Instance> Neighborhood<M, S, I> interleave(Neighborhood<M, S, I>... neighborhoods) {
         return new InterleavedNeighborhood<>(neighborhoods);
     }
@@ -107,6 +109,7 @@ public static <M extends Move<S, I>, S extends Solution<S, I>, I extends Instanc
      * @param <I> Instance type
      */
     @SafeVarargs
+    @SuppressWarnings("varargs")
     public static <M extends Move<S, I>, S extends Solution<S, I>, I extends Instance> RandomizableNeighborhood<M, S, I> random(boolean balanced, RandomizableNeighborhood<M, S, I>... neighborhoods) {
         return new RandomFromNeighborhood<>(balanced, neighborhoods);
     }
@@ -210,8 +213,7 @@ private Optional<M> balancedPick(S solution) {
     private abstract static class DerivedNeighborhood<M extends Move<S, I>, S extends Solution<S, I>, I extends Instance> extends Neighborhood<M, S, I> {
         final Neighborhood<M, S, I>[] neighborhoods;
 
-        @SafeVarargs
-        public DerivedNeighborhood(Neighborhood<M, S, I>... neighborhoods) {
+        public DerivedNeighborhood(Neighborhood<M, S, I>[] neighborhoods) {
             this.neighborhoods = Objects.requireNonNull(neighborhoods);
         }
 
@@ -230,6 +232,7 @@ public String toString() {
     private static class ConcatNeighborhood<M extends Move<S, I>, S extends Solution<S, I>, I extends Instance> extends DerivedNeighborhood<M, S, I> {
 
         @SafeVarargs
+        @SuppressWarnings("varargs")
         private ConcatNeighborhood(Neighborhood<M, S, I>... neighborhoods) {
             super(neighborhoods);
         }
@@ -260,6 +263,7 @@ public ExploreResult<M, S, I> explore(S solution) {
     private static class InterleavedNeighborhood<M extends Move<S, I>, S extends Solution<S, I>, I extends Instance> extends DerivedNeighborhood<M, S, I> {
 
         @SafeVarargs
+        @SuppressWarnings("varargs")
         private InterleavedNeighborhood(Neighborhood<M, S, I>... neighborhoods) {
             super(neighborhoods);
         }
@@ -286,7 +290,7 @@ public ExploreResult<M, S, I> explore(S solution) {
             }
 
             return new ExploreResult<>(StreamSupport.stream(new Spliterators.AbstractSpliterator<>(totalSize, ch) {
-                List<Spliterator<? extends M>> spliterators = sps;
+                final List<Spliterator<? extends M>> spliterators = sps;
                 int lastIndex = 0;
 
                 @Override

common/src/main/java/es/urjc/etsii/grafo/util/StreamUtil.java

@@ -16,6 +16,7 @@ public class StreamUtil {
      * @return A single stream containing all the given streams
      */
     @SafeVarargs
+    @SuppressWarnings("varargs")
     public static <T> Stream<T> merge(Stream<T>... streams){
         return Arrays.stream(streams).flatMap(s -> s);
     }

common/src/main/java/es/urjc/etsii/grafo/util/graph_algorithms/Dinic.java

@@ -6,7 +6,10 @@
 // Commented and Edited by Arup Guha on 3/6/2017 for COP 4516
 // Code for Dinic's Network Flow Algorithm
 
-import java.util.*;
+import java.util.ArrayDeque;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.Objects;
 
 /**
  * Dinic's algorithm for the maxflow problem.
@@ -32,7 +35,7 @@ public class Dinic {
      *
      * @param N graph size
      */
-    @SuppressWarnings("unchecked") // due to required (HashSet<Edge>[]) cast
+    @SuppressWarnings({"unchecked", "rawtypes"}) // due to required (HashSet<Edge>[]) cast
     public Dinic(int N) {
 
         // s is the source, t is the sink, add these as last two nodes.

common/src/test/java/es/urjc/etsii/grafo/solution/neighborhood/NeighborhoodTest.java

@@ -9,6 +9,7 @@
 
 import java.util.stream.Stream;
 
+@SuppressWarnings("unchecked")
 public class NeighborhoodTest {
 
     TestSolution solution;

common/src/test/java/es/urjc/etsii/grafo/util/collections/BitSetTest.java

@@ -313,7 +313,7 @@ void testCloneSet(){
         for (int i = 0; i < size; i++) {
             set1.add(r.nextInt(size));
         }
-        var set2 = (BitSet) set1.clone();
+        var set2 = set1.clone();
         assertEquals(set1, set2);
         assertEquals(set1.hashCode(), set2.hashCode());
 

example-tsp/src/main/java/es/urjc/etsii/grafo/TSP/drawing/DotGenerator.java

@@ -23,7 +23,7 @@ public class DotGenerator {
     /**
      * Common features for all files.
      * Layout is set as "neato", other layout as "dot", "fdp", "sfdp" "twopi" or "circo" can be selected.
-     * More information: https://www.graphviz.org
+     * More information: <a href="https://www.graphviz.org">Graphviz website</a>
      */
     private static final String header = """
             digraph G {
@@ -35,9 +35,9 @@ public class DotGenerator {
      */
     private static final String footer = "\n}";
 
-    private final AbstractEventStorage eventStorage;
+    private final AbstractEventStorage<?,?> eventStorage;
 
-    public DotGenerator(MemoryEventStorage eventStorage) {
+    public DotGenerator(MemoryEventStorage<?,?> eventStorage) {
         this.eventStorage = eventStorage;
     }
 
@@ -102,7 +102,7 @@ private static double normalize(double value, double min, double max) {
     @GetMapping("/api/generategraph/{eventId}")
     public String getSolutionAsDotString(@PathVariable int eventId) throws IOException {
         var event =  eventStorage.getEvent(eventId);
-        if(event instanceof SolutionGeneratedEvent solutionGeneratedEvent && solutionGeneratedEvent.getSolution().isPresent()){
+        if(event instanceof SolutionGeneratedEvent<?,?> solutionGeneratedEvent && solutionGeneratedEvent.getSolution().isPresent()){
             var solution = (TSPSolution) solutionGeneratedEvent.getSolution().get();
             var viz = Graphviz.fromString(generateDotDiagram(solution));
             BufferedImage image = viz.render(Format.PNG).toImage();

example-tsp/src/test/java/es/urjc/etsii/tsptests/SmokeTest.java

@@ -26,7 +26,7 @@ class SmokeTest {
     private Executor<?, ?> executor;
 
     @Autowired
-    private AbstractEventStorage abstractEventStorage;
+    private AbstractEventStorage<?,?> abstractEventStorage;
 
     @Autowired
     private ApplicationContext applicationContext;

pom.xml

@@ -203,6 +203,7 @@
                 <configuration>
                     <compilerArgs>
                         <arg>-parameters</arg>
+                        <arg>-Xlint:all,-this-escape</arg>
                     </compilerArgs>
                 </configuration>
             </plugin>