Skip to content

refactor: clean up @alert deprecated pragmas #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buffer/buffer.mbt
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// limitations under the License.

///| Extensible buffer.
/// @alert deprecated "Use type `T` instead"
#deprecated("Use type `T` instead")
pub(all) typealias Buffer = T

///|
Expand Down
2 changes: 1 addition & 1 deletion builtin/arrayview.mbt
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
/// assert_eq!(view[0], 2)
/// assert_eq!(view.length(), 3)
/// ```
/// @alert deprecated "use @array.View instead"
#deprecated("use @array.View instead")
struct ArrayView[T] {
buf : UninitializedArray[T]
start : Int
Expand Down
2 changes: 1 addition & 1 deletion builtin/builtin.mbti
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ impl[T : Hash] Hash for Array[T]
impl[X : Show] Show for Array[X]
impl[X : ToJson] ToJson for Array[X]

type ArrayView[T] //deprecated
type ArrayView[T]
impl ArrayView {
length[T](Self[T]) -> Int
op_as_view[T](Self[T], start~ : Int = .., end? : Int) -> Self[T]
Expand Down
2 changes: 1 addition & 1 deletion json/types.mbt
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// limitations under the License.

///|
/// @alert deprecated "Definition of json is moved to builtin package, use `Json` instead"
#deprecated("Definition of json is moved to builtin package, use `Json` instead")
pub(all) typealias JsonValue = Json

///|
Expand Down
2 changes: 1 addition & 1 deletion strconv/decimal.mbt
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
/// reference:
/// - <https://nigeltao.github.io/blog/2020/parse-number-f64-simple.html>
/// - <https://nigeltao.github.io/blog/2020/eisel-lemire.html>
/// @alert deprecated "Decimal will be changed to private. Use `@strconv.parse_double` instead"
#deprecated("Decimal will be changed to private. Use `@strconv.parse_double` instead")
struct Decimal {
digits : FixedArray[Byte]
mut digits_num : Int
Expand Down
2 changes: 1 addition & 1 deletion strconv/strconv.mbti
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ fn shift(Decimal, Int) -> Unit
fn to_double(Decimal) -> Double!StrConvError //deprecated

// Types and methods
type Decimal //deprecated
type Decimal
impl Decimal {
#deprecated
from_int64(Int64) -> Self
Expand Down
Loading