Breaking Change: make String::op_get return Int

[Yu-zh]

No description provided.

[peter-jerry-ye-code-review]

Type signature update needs matching documentation update

Category
Correctness
Code Snippet
pub fn String::op_get(self : String, idx : Int) -> Int = "%string_get"
Recommendation
Add documentation explaining that the function now returns the Unicode code point (as Int) instead of the character
Reasoning
The change from Char to Int return type is significant and should be clearly documented to avoid confusion for users of the API

Interface consistency between String::get and String::op_get

Category
Maintainability
Code Snippet
get(String, Int) -> Char
op_get(String, Int) -> Int
Recommendation
Consider aligning the behavior of get() and op_get(), or document why they return different types for the same operation
Reasoning
Having two similar indexing operations that return different types (Char vs Int) could be confusing for users. The difference in behavior should be justified and documented

Test cases could be more comprehensive

Category
Maintainability
Code Snippet
test "String::op_get" {
inspect!(s[0], content="72")
inspect!(s[7], content="19990")
}
Recommendation
Add test cases for non-ASCII characters in different positions, and edge cases like the last character in the string
Reasoning
Current tests only check two specific cases. More comprehensive testing would ensure the behavior is correct across different character types and positions

[coveralls]

Pull Request Test Coverage Report for Build 6524

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 92.736%

---

Totals
Change from base Build 6521:	0.0%
Covered Lines:	6128
Relevant Lines:	6608

---

💛 - Coveralls