Breaking Change: make String::op_get return Int

[Yu-zh]

No description provided.

[peter-jerry-ye-code-review]

Documentation needs to be updated to reflect the return type change

Category
Maintainability
Code Snippet
pub fn String::op_get(self : String, idx : Int) -> Int = "%string_get"
Recommendation
Add documentation explaining that the function now returns the Unicode code point (Int) instead of a Char
Reasoning
The change from Char to Int is significant for API users and should be clearly documented to avoid confusion. Users need to know they're getting a numeric code point instead of a character.

Consider adding helper method for character code point conversion

Category
Maintainability
Code Snippet
test "String::op_get" {
let s = "Hello, 世界!"
inspect!(s[0], content="72")
inspect!(s[7], content="19990")
}
Recommendation
Add a utility function to convert between Int code points and Char, like from_code_point(i: Int) -> Char
Reasoning
Since the indexing operation now returns code points instead of characters, users might frequently need to convert between the two. A helper method would improve usability.

Panic message for out-of-bounds might need update

Category
Correctness
Code Snippet
test "panic String::op_get/out_of_bounds" {
let s = "Hello"
s[-1]
}
Recommendation
Ensure the panic message mentions that the operation returns a code point, if it currently mentions returning a character
Reasoning
Error messages should be consistent with the actual behavior of the function to avoid misleading users when errors occur.

[coveralls]

Pull Request Test Coverage Report for Build 6285

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 91.834%

---

Totals
Change from base Build 6283:	0.0%
Covered Lines:	5679
Relevant Lines:	6184

---

💛 - Coveralls