Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_crawler in python is case sensitive now. #381

Closed
jurasans opened this issue Dec 17, 2024 · 1 comment
Closed

is_crawler in python is case sensitive now. #381

jurasans opened this issue Dec 17, 2024 · 1 comment

Comments

@jurasans
Copy link
Contributor

jurasans commented Dec 17, 2024 •
edited
Loading

In a project I work on, the crawler detection makes the user-agent string uniform by lowercasing the user-agent string before passing into the crawler detection.

In the past this worked fine, but now after the sep 6 commit (and subsequent release) we started having issues with the detection of crawlers.

THIS BREAK BACKWARDS COMPATIBILITY
@jurasans jurasans changed the title IsCrawler in python is case sensitive now. is_Crawler in python is case sensitive now. Dec 17, 2024
@jurasans jurasans changed the title is_Crawler in python is case sensitive now. is_crawler in python is case sensitive now. Dec 17, 2024
@jurasans jurasans mentioned this issue Dec 17, 2024
Merged
@monperrus
Copy link
Owner

fixed by #382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@monperrus @jurasans