Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow tape looping behavior to be changed #1789

Open
catfact opened this issue Jul 8, 2024 · 3 comments
Open

allow tape looping behavior to be changed #1789

catfact opened this issue Jul 8, 2024 · 3 comments

Comments

@catfact
Copy link
Collaborator

catfact commented Jul 8, 2024

this behavior is actually controlled by a runtime flag called loopFile within the Tape module, but it does not have public setters. i believe adding setter and corresponding OSC handler would be sufficient to toggle looping.

https://github.com/monome/norns/blob/main/crone/src/Tape.h#L346

might be good to expose this to OSC / lua.

@tehn
Copy link
Member

tehn commented Jul 9, 2024

this would be good.

it doesn't seem like there's a good place in the PARAMETER menu that makes sense to control this (short of adding a new SUB for tape, which this would be the only option).

alternatively, i propose a minor rework of the TAPE UI:

  • E2 (scroll) switches between PLAY and REC (which follows existing UI for up/down)
  • K2 cancels an armed PLAY or REC (currently there's no way to cancel, and this would also follow existing conventions.) presently this toggles between PLAY and REC (i don't know why i made this decision)
  • E3 in PLAY toggles loop mode

if this seems like a good idea, i can work on this next week

@tehn tehn self-assigned this Jul 9, 2024
@dndrks
Copy link
Member

dndrks commented Jul 10, 2024

combing through old tickets surfaced: #766
@tehn , re: K2 -- could 'canceling' an in-progress PLAY inherit the current STOP functionality, leaving K3 free for PAUSE?

@tehn
Copy link
Member

tehn commented Jul 10, 2024

the UI opportunity is clear, but the tape module presently doesn't have a PAUSE state so that's an additional feature

@tehn tehn removed their assignment Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants