Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NODE-6729): move to new benchmark runner #4405

Merged
merged 3 commits into from
Feb 10, 2025
Merged

chore(NODE-6729): move to new benchmark runner #4405

merged 3 commits into from
Feb 10, 2025

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Feb 7, 2025 •
edited
Loading

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Migrate to the new runner.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the NODE-6729-moving-day branch from 7f0247d to b1b0e64 Compare February 7, 2025 16:53
@nbbeeken nbbeeken force-pushed the NODE-6705-parallel-benchies branch from e3904a4 to 6a61748 Compare February 7, 2025 19:11
@nbbeeken nbbeeken force-pushed the NODE-6729-moving-day branch 2 times, most recently from a89abf0 to bb62802 Compare February 7, 2025 20:20
@nbbeeken nbbeeken force-pushed the NODE-6705-parallel-benchies branch from 6a61748 to 8936770 Compare February 7, 2025 21:11
@nbbeeken nbbeeken force-pushed the NODE-6729-moving-day branch from bb62802 to c809a5f Compare February 7, 2025 21:39
Base automatically changed from NODE-6705-parallel-benchies to main February 10, 2025 06:42
@nbbeeken nbbeeken force-pushed the NODE-6729-moving-day branch from c809a5f to a2b6fc5 Compare February 10, 2025 17:46
@nbbeeken nbbeeken marked this pull request as ready for review February 10, 2025 17:54
@nbbeeken nbbeeken requested a review from a team as a code owner February 10, 2025 17:54
@baileympearson baileympearson self-assigned this Feb 10, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 10, 2025
@baileympearson
Copy link
Contributor

CI failures unrelated. Perf tests look good and reports show in CI.

@baileympearson baileympearson merged commit 7bfce01 into main Feb 10, 2025
24 of 30 checks passed
@baileympearson baileympearson deleted the NODE-6729-moving-day branch February 10, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @baileympearson