Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON-5199 Fix handling of MongoDB version in run-server #2193

Merged
merged 2 commits into from
Mar 12, 2025
Merged

PYTHON-5199 Fix handling of MongoDB version in run-server #2193

merged 2 commits into from
Mar 12, 2025

Conversation

blink1073
Copy link
Member 

VERSION=8.0 just run-server
bash .evergreen/scripts/run-server.sh
Sourcing env file
INFO     Running command 'bash /Users/steve.silvester/workspace/drivers-evergreen-tools/.evergreen/run-orchestration.sh'...
Ensuring python binary...
Ensuring python binary... done.
Creating virtual environment 'venv'...
Creating virtual environment 'venv'... done.
uv is /opt/homebrew/bin/uv
INFO     Running orchestration...
INFO     Downloading mongodb 8.0...

@blink1073 blink1073 requested a review from NoahStapp March 12, 2025 12:39
NoahStapp
NoahStapp requested changes Mar 12, 2025
View reviewed changes
.evergreen/scripts/run_server.py Outdated
@@ -18,6 +18,10 @@ def start_server():
)
test_name = opts.test_name

# drivers-evergreen-tools expects the version variable to be named MONGOD_VERSION.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the variable name supposed to be MONGODB_VERSION as below or MONGOD_VERSION as the comment suggests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@blink1073 blink1073 requested a review from NoahStapp March 12, 2025 13:51
@blink1073
Copy link
Member Author

Spot check from a 4.2 run: db version v4.2.25.

@blink1073 blink1073 merged commit 4322fdf into mongodb:master Mar 12, 2025
34 of 37 checks passed
@blink1073 blink1073 deleted the PYTHON-5199 branch March 12, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahStapp NoahStapp NoahStapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @NoahStapp