Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON-5187 Add scripts to start and stop a server #2184

Merged
merged 7 commits into from
Mar 6, 2025
Merged

PYTHON-5187 Add scripts to start and stop a server #2184

merged 7 commits into from
Mar 6, 2025

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073 blink1073 requested a review from NoahStapp March 6, 2025 19:13
NoahStapp
NoahStapp previously approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming tests pass!

@blink1073
Copy link
Member Author

blink1073 commented Mar 6, 2025 •
edited
Loading

I pushed an update to improve usability:

  • Add a description to each help text
  • Show the appropriate args and arg descriptions for each help text
  • Allow passing through the CLI flags to run-orchestration.sh

@blink1073 blink1073 requested a review from NoahStapp March 6, 2025 20:58
@blink1073 blink1073 merged commit 3653984 into mongodb:master Mar 6, 2025
35 of 37 checks passed
@blink1073 blink1073 deleted the PYTHON-5187 branch March 6, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahStapp NoahStapp NoahStapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @NoahStapp