PYTHON-4991 Fix perf client.bulkWrite perf regression #2056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PYTHON-4991 Fix perf client.bulkWrite perf regression
Explanation: I noticed that the perf regression applied equally to both small and large documents which wouldn't make sense if the overhead was only attributed to the allocation cost of ChainMaps. For this regression to apply to larger documents, that must mean that there's also a performance cost when iterating over the ChainMap in the encoding step (something I had not expected).
Instead we can encode the document directly so that it gets recognized as a "top-level" document, then the existing
_id
reordering logic will be applied. Running the perf tests on this PR will confirm.Perf task running here: https://spruce.mongodb.com/task/mongo_python_driver_perf_tests_perf_8.0_standalone_patch_493fc2ab3e237c2155fde4400002ed2aafe9b2be_67817f2e6497de0007ec294b_25_01_10_20_12_36/logs?execution=0