Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some improvement to gradle usage #67

Merged
merged 1 commit into from
Mar 17, 2025
Merged

some improvement to gradle usage #67

merged 1 commit into from
Mar 17, 2025

Conversation

NathanQingyangXu
Copy link
Contributor

@NathanQingyangXu NathanQingyangXu commented Mar 14, 2025 •
edited
Loading

got some inspiration from reviewing Ross's gradle modernization PR.
Changes include:

  • moved tripple quote indentation spotless into a customized gradle plugin "spotless-java-extention", so our main build.gradle.kts won't lose focus on big picture
  • changed BuildConfig java's package from com.mongo.hibernate to com.mongo.hibernate.internal
  • enriched the kts spotless formatting configuration
  • exploited bundles toml feature to decrease common test dependencies duplication
  • misc minor improvements

@NathanQingyangXu NathanQingyangXu force-pushed the some-improvement-to-gradle-usage branch from 794fd09 to f02a5a4 Compare March 14, 2025 05:12
@jyemin jyemin requested review from rozza and removed request for stIncMale March 14, 2025 13:19
@NathanQingyangXu NathanQingyangXu force-pushed the some-improvement-to-gradle-usage branch 2 times, most recently from 20561b8 to 6cdcb69 Compare March 17, 2025 02:03
@NathanQingyangXu NathanQingyangXu force-pushed the some-improvement-to-gradle-usage branch from 6cdcb69 to 7c0b93c Compare March 17, 2025 02:04
rozza
rozza approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions - but nothing that blocks a LGTM.

@NathanQingyangXu NathanQingyangXu merged commit 804af82 into mongodb:main Mar 17, 2025
6 checks passed
@NathanQingyangXu NathanQingyangXu deleted the some-improvement-to-gradle-usage branch March 17, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozza rozza rozza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NathanQingyangXu @rozza