Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXX-2745 fix missing include directives for SSL-related config macros #1333

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

eramongodb
Copy link
Collaborator

@eramongodb eramongodb commented Feb 12, 2025

Followup to #1323 to address atlas-search-indexes-matrix task failures due to incorrect SSL configuration detection based on MONGOCXX_ENABLE_SSL and MONGOC_ENABLE_SSL macros which (incorrectly) may not be defined due to missing include directives, leading to false-positive "SSL support not available" exceptions.

@eramongodb eramongodb requested a review from kevinAlbs February 12, 2025 22:08
@eramongodb eramongodb self-assigned this Feb 12, 2025
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

src/mongocxx/test/pool.cpp Outdated Show resolved Hide resolved
src/mongocxx/lib/mongocxx/v_noabi/mongocxx/client.cpp Outdated Show resolved Hide resolved
@eramongodb eramongodb requested a review from kevinAlbs February 13, 2025 17:41
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eramongodb eramongodb merged commit 86096f8 into mongodb:master Feb 13, 2025
4 of 6 checks passed
@eramongodb eramongodb deleted the cxx-2745 branch February 13, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants