CSHARP-5473: Provide API to turn LINQ expression into MQL. #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstam
requested review from
JamesKovacs,
damieng,
BorisDog,
sanych-sun and
adelinowona
sanych-sun
requested changes
Jan 29, 2025
| public class CSharp5473Tests : Linq3IntegrationTest | ||
| { | ||
| [Fact] | ||
| public void Select_decimal_divide_should_work() |
There was a problem hiding this comment.
Minor : Test method name seems to be wrong.
| var stages = provider.Translate(queryable, out var outputSerializer); | ||
| AssertStages(stages, "{ $project : { _v : { $add : ['$X', 1] }, _id : 0 } }"); | ||
|
|
||
| var result = queryable.First(); |
There was a problem hiding this comment.
Should we try to execute translated MQL in some way instead to make sure the translation was done properly?
There was a problem hiding this comment.
Yes, but not necessarily to verify that the translation was done correctly.
I'm more interested in showing HOW you could execute the result of Translate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BIG question for this PR is whether we want to do this at all, and if so what the public API should be.