-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: incorrectly attempting access to sign release artifacts variables #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditi-khare-mongoDB
changed the title
Node 6156/sign release artifacts temp test
fix: sign release artifacts variable incorrect access
May 28, 2024
aditi-khare-mongoDB
changed the title
fix: sign release artifacts variable incorrect access
fix: sign release artifacts variable incorrectly accessed
May 28, 2024
aditi-khare-mongoDB
changed the title
fix: sign release artifacts variable incorrectly accessed
fix: incorrectly access sign release artifacts variables
May 28, 2024
aditi-khare-mongoDB
changed the title
fix: incorrectly access sign release artifacts variables
fix: incorrectly attempting access to sign release artifacts variables
May 28, 2024
W-A-James
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
May 29, 2024
W-A-James
reviewed
May 29, 2024
W-A-James
approved these changes
May 29, 2024
W-A-James
changed the title
fix: incorrectly attempting access to sign release artifacts variables
chore: incorrectly attempting access to sign release artifacts variables
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this fix, the access to the steps.<step_id_name>.outputs.<vars_name> was incorrectly formatted.
This is a very small change (pay no mind to the 36 commits, that's just due to the same branch name being reused).
What is changing?
gh release upload
now has the correct files, as does garasign.Is there new documentation needed for these changes?
No.
What is the motivation for this change?
Bug fix for SSDLC.
Release Highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript