refactor: move swapping to ByteUtils

mongodb · Nov 18, 2024 · a0c63c1 · a0c63c1
1 parent e8d6062
commit a0c63c1
Show file tree

Hide file tree

Showing 5 changed files with 56 additions and 29 deletions.
diff --git a/src/binary.ts b/src/binary.ts
@@ -364,18 +364,9 @@ export class Binary extends BSONValue {
     const floatBytes = new Uint8Array(
       this.buffer.buffer.slice(this.buffer.byteOffset + 2, this.buffer.byteOffset + this.position)
     );
-    if (NumberUtils.isBigEndian) {
-      for (let i = 0; i < floatBytes.byteLength; i += 4) {
-        const byte0 = floatBytes[i];
-        const byte1 = floatBytes[i + 1];
-        const byte2 = floatBytes[i + 2];
-        const byte3 = floatBytes[i + 3];
-        floatBytes[i] = byte3;
-        floatBytes[i + 1] = byte2;
-        floatBytes[i + 2] = byte1;
-        floatBytes[i + 3] = byte0;
-      }
-    }
+
+    if (NumberUtils.isBigEndian) ByteUtils.swap32(floatBytes);
+
     return new Float32Array(floatBytes.buffer);
   }
 
@@ -455,18 +446,7 @@ export class Binary extends BSONValue {
     const floatBytes = new Uint8Array(array.buffer, array.byteOffset, array.byteLength);
     binaryBytes.set(floatBytes, 2);
 
-    if (NumberUtils.isBigEndian) {
-      for (let i = 2; i < binaryBytes.byteLength; i += 4) {
-        const byte0 = binaryBytes[i];
-        const byte1 = binaryBytes[i + 1];
-        const byte2 = binaryBytes[i + 2];
-        const byte3 = binaryBytes[i + 3];
-        binaryBytes[i] = byte3;
-        binaryBytes[i + 1] = byte2;
-        binaryBytes[i + 2] = byte1;
-        binaryBytes[i + 3] = byte0;
-      }
-    }
+    if (NumberUtils.isBigEndian) ByteUtils.swap32(new Uint8Array(binaryBytes.buffer, 2));
 
     return new this(binaryBytes, this.SUBTYPE_VECTOR);
   }

diff --git a/src/utils/byte_utils.ts b/src/utils/byte_utils.ts
@@ -39,6 +39,8 @@ export type ByteUtils = {
   encodeUTF8Into: (destination: Uint8Array, source: string, byteOffset: number) => number;
   /** Generate a Uint8Array filled with random bytes with byteLength */
   randomBytes: (byteLength: number) => Uint8Array;
+  /** Interprets `buffer` as an array of 32-bit values and swaps the byte order in-place. */
+  swap32: (buffer: Uint8Array) => Uint8Array;
 };
 
 declare const Buffer: { new (): unknown; prototype?: { _isBuffer?: boolean } } | undefined;

diff --git a/src/utils/node_byte_utils.ts b/src/utils/node_byte_utils.ts
@@ -9,6 +9,7 @@ type NodeJsBuffer = ArrayBufferView &
     copy(target: Uint8Array, targetStart: number, sourceStart: number, sourceEnd: number): number;
     toString: (this: Uint8Array, encoding: NodeJsEncoding, start?: number, end?: number) => string;
     equals: (this: Uint8Array, other: Uint8Array) => boolean;
+    swap32: (this: NodeJsBuffer) => NodeJsBuffer;
   };
 type NodeJsBufferConstructor = Omit<Uint8ArrayConstructor, 'from'> & {
   alloc: (size: number) => NodeJsBuffer;
@@ -159,5 +160,9 @@ export const nodeJsByteUtils = {
     return nodeJsByteUtils.toLocalBufferType(buffer).write(source, byteOffset, undefined, 'utf8');
   },
 
-  randomBytes: nodejsRandomBytes
+  randomBytes: nodejsRandomBytes,
+
+  swap32(buffer: Uint8Array): NodeJsBuffer {
+    return nodeJsByteUtils.toLocalBufferType(buffer).swap32();
+  }
 };
diff --git a/src/utils/web_byte_utils.ts b/src/utils/web_byte_utils.ts
@@ -193,5 +193,24 @@ export const webByteUtils = {
     return bytes.byteLength;
   },
 
-  randomBytes: webRandomBytes
+  randomBytes: webRandomBytes,
+
+  swap32(buffer: Uint8Array): Uint8Array {
+    if (buffer.length % 4 !== 0) {
+      throw new RangeError('Buffer size must be a multiple of 32-bits');
+    }
+
+    for (let i = 0; i < buffer.length; i += 4) {
+      const byte0 = buffer[i];
+      const byte1 = buffer[i + 1];
+      const byte2 = buffer[i + 2];
+      const byte3 = buffer[i + 3];
+      buffer[i] = byte3;
+      buffer[i + 1] = byte2;
+      buffer[i + 2] = byte1;
+      buffer[i + 3] = byte0;
+    }
+
+    return buffer;
+  }
 };
diff --git a/test/node/byte_utils.test.ts b/test/node/byte_utils.test.ts
@@ -12,7 +12,7 @@ import { utf8WebPlatformSpecTests } from './data/utf8_wpt_error_cases';
 
 type ByteUtilTest<K extends keyof ByteUtils> = {
   name: string;
-  inputs: Parameters<ByteUtils[K]>;
+  inputs: Parameters<ByteUtils[K]> | (() => Parameters<ByteUtils[K]>);
   expectation: (result: {
     web: boolean;
     output: ReturnType<ByteUtils[K]> | null;
@@ -500,6 +500,23 @@ const randomBytesTests: ByteUtilTest<'randomBytes'>[] = [
     }
   }
 ];
+const swap32Tests: ByteUtilTest<'swap32'>[] = [
+  {
+    name: 'swaps byte order in-place',
+    inputs: () => [Buffer.from([1, 2, 3, 4, 5, 6, 7, 8])],
+    expectation({ output, error }) {
+      expect(error).to.be.null;
+      expect(output).to.deep.equal(Buffer.from([4, 3, 2, 1, 8, 7, 6, 5]));
+    }
+  },
+  {
+    name: 'throws if buffer is not a multiple of 4 bytes',
+    inputs: [Buffer.from([1, 2, 3])],
+    expectation({ error }) {
+      expect(error).to.be.instanceOf(RangeError);
+    }
+  }
+];
 
 const utils = new Map([
   ['nodeJsByteUtils', nodeJsByteUtils],
@@ -520,7 +537,8 @@ const table = new Map<keyof ByteUtils, ByteUtilTest<keyof ByteUtils>[]>([
   ['encodeUTF8Into', fromUTF8Tests],
   ['toUTF8', toUTF8Tests],
   ['utf8ByteLength', utf8ByteLengthTests],
-  ['randomBytes', randomBytesTests]
+  ['randomBytes', randomBytesTests],
+  ['swap32', swap32Tests]
 ]);
 
 describe('ByteUtils', () => {
@@ -790,7 +808,10 @@ describe('ByteUtils', () => {
             let error = null;
 
             try {
-              output = byteUtils[utility].call(null, ...test.inputs);
+              output = byteUtils[utility].call(
+                null,
+                ...(typeof test.inputs === 'function' ? test.inputs() : test.inputs)
+              );
             } catch (thrownError) {
               error = thrownError;
             }