This repository has been archived by the owner on Oct 18, 2021. It is now read-only.
Macros #57
Merged
Macros #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "title" => Bson::String("Back to the Future".to_owned()) | ||
| }; | ||
|
|
||
| // let mut doc = bson::Document::new(); |
There was a problem hiding this comment.
why is this commented out and not removed?
|
lgtm modulo details with commented out code |
|
Also, @steveklabnik, this is our first attempt at using macros for building up bson docs. It's admittedly naive but works well thus far. Do you have any suggestions for improvements? |
vkarpov15
added a commit
that referenced
this pull request
Jun 18, 2015
|
I am really bad at macros but seems fine. You might want to look at what other people have done for hashmaps... for example, rust-lang/rust#14726 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.