Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-181 Revert nested document behavior and document limitation #173

Merged
merged 3 commits into from
Oct 16, 2023
Merged

ARROW-181 Revert nested document behavior and document limitation #173

merged 3 commits into from
Oct 16, 2023

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073 blink1073 removed the request for review from ShaneHarvey October 16, 2023 16:17
NoahStapp
NoahStapp approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, where did the decision to revert come from? Are we still planning to write a custom builder to alleviate the performance concerns?

@blink1073
Copy link
Member Author

The decision came from discussion in #169. We have ARROW-179 tracking the full fix.

@blink1073 blink1073 merged commit 1e25090 into mongodb-labs:main Oct 16, 2023
@blink1073 blink1073 deleted the ARROW-181 branch October 16, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahStapp NoahStapp NoahStapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @NoahStapp