fix: disable saved Connections Loaded event (#585)

mongodb-js · Aug 23, 2023 · 801c9b7 · 801c9b7
1 parent 896ac37
commit 801c9b7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/connectionController.ts b/src/connectionController.ts
@@ -222,7 +222,9 @@ export default class ConnectionController {
       this.eventEmitter.emit(DataServiceEventTypes.CONNECTIONS_DID_CHANGE);
     }
 
-    this._telemetryService.trackSavedConnectionsLoaded({
+    // TODO: re-enable with fewer 'Saved Connections Loaded' events
+    // https://jira.mongodb.org/browse/VSCODE-462
+    /* this._telemetryService.trackSavedConnectionsLoaded({
       saved_connections: globalAndWorkspaceConnections.length,
       loaded_connections: loadedConnections.length,
       connections_with_secrets_in_keytar: loadedConnections.filter(
@@ -234,7 +236,7 @@ export default class ConnectionController {
           connection.secretStorageLocation ===
           SecretStorageLocation.SecretStorage
       ).length,
-    });
+    }); */
 
     if (connectionsThatDidNotMigrate.length) {
       log.error(

diff --git a/src/test/suite/connectionController.test.ts b/src/test/suite/connectionController.test.ts
@@ -1762,7 +1762,7 @@ suite('Connection Controller Test Suite', function () {
       assert.strictEqual(trackStub.notCalled, true);
     });
 
-    test('should track SAVED_CONNECTIONS_LOADED event on load of saved connections', async () => {
+    test.skip('should track SAVED_CONNECTIONS_LOADED event on load of saved connections', async () => {
       testSandbox.replace(testStorageController, 'get', (key, storage) => {
         if (
           storage === StorageLocation.WORKSPACE ||

diff --git a/src/test/suite/telemetry/telemetryService.test.ts b/src/test/suite/telemetry/telemetryService.test.ts
@@ -717,7 +717,7 @@ suite('Telemetry Controller Test Suite', () => {
     });
   });
 
-  test('track saved connections loaded', () => {
+  test.skip('track saved connections loaded', () => {
     testTelemetryService.trackSavedConnectionsLoaded({
       saved_connections: 3,
       loaded_connections: 3,