From d300139025bea80162924116d86a8912af4c2641 Mon Sep 17 00:00:00 2001
From: bompus <bompus@gmail.com>
Date: Wed, 13 Mar 2019 09:42:45 -0700
Subject: [PATCH 1/2] Added load balancing to connection pool

Load balance our pool connections, sending next workItem to connection with least number of already-pending workItems. Eliminates need for connectionIndex.
---
 lib/connection/pool.js | 33 ++++++++++++++++++++++++---------
 1 file changed, 24 insertions(+), 9 deletions(-)

diff --git a/lib/connection/pool.js b/lib/connection/pool.js
index 6cd1a9e3c..71c98adc6 100644
--- a/lib/connection/pool.js
+++ b/lib/connection/pool.js
@@ -141,8 +141,6 @@ var Pool = function(topology, options) {
 
   // Number of consecutive timeouts caught
   this.numberOfConsecutiveTimeouts = 0;
-  // Current pool Index
-  this.connectionIndex = 0;
 
   // event handlers
   const pool = this;
@@ -1069,15 +1067,32 @@ function _execute(self) {
         break;
       }
 
-      var connection = null;
-      const connections = self.availableConnections.filter(conn => conn.workItems.length === 0);
+      // Load balance our pool connections, sending next workItem to connection with least number of already-pending workItems
+      var tmpConn = null;
+      var workItemsLen = 0;
+      var min = Number.POSITIVE_INFINITY;
+      var connections = [];
+
+      for (var i = 0; i < self.availableConnections.length; i++) {
+        tmpConn = self.availableConnections[i];
+        workItemsLen = tmpConn.workItems.length;
+
+        if (workItemsLen <= min) {
+          if (workItemsLen < min) {
+            min = workItemsLen;
+            connections = [tmpConn];
+          } else {
+            connections.push(tmpConn);
+          }
+        }
+      }
 
-      // No connection found that has no work on it, just pick one for pipelining
-      if (connections.length === 0) {
-        connection =
-          self.availableConnections[self.connectionIndex++ % self.availableConnections.length];
+      var connection = null;
+      if (connections.length === 1) {
+        connection = connections[0];
       } else {
-        connection = connections[self.connectionIndex++ % connections.length];
+        // We have multiple connections with an equal low-number of workItems, pick a random one
+        connection = connections[Math.floor(Math.random() * connections.length)];
       }
 
       // Is the connection connected

From 890c762e03320e588c862f84fdcfe270d68bcc62 Mon Sep 17 00:00:00 2001
From: bompus <bompus@gmail.com>
Date: Wed, 13 Mar 2019 10:00:31 -0700
Subject: [PATCH 2/2] Added load balancing to connection pool

Simpified a conditional
---
 lib/connection/pool.js | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/lib/connection/pool.js b/lib/connection/pool.js
index 71c98adc6..76b4fb171 100644
--- a/lib/connection/pool.js
+++ b/lib/connection/pool.js
@@ -1077,13 +1077,11 @@ function _execute(self) {
         tmpConn = self.availableConnections[i];
         workItemsLen = tmpConn.workItems.length;
 
-        if (workItemsLen <= min) {
-          if (workItemsLen < min) {
-            min = workItemsLen;
-            connections = [tmpConn];
-          } else {
-            connections.push(tmpConn);
-          }
+        if (workItemsLen < min) {
+          min = workItemsLen;
+          connections = [tmpConn];
+        } else if (workItemsLen === min) {
+          connections.push(tmpConn);
         }
       }