-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support vitest #2625
fix: support vitest #2625
Conversation
A new prerelease version of this PR has been published! 🎉 To update
Or with npm:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't process.env.NODE_ENV === "test"
also in vitest?
Yes but vitest can't handle |
so maybe worth leaving the NODE_ENV one as well |
btw its really weird that this code should lay in the component itself, is it really a must in order to do lazy load? |
why? It was for jest because jest isn't very good with esm while vitest is quite the opposite. This check covers both |
unfortunately yes, do you have other idea? |
A new prerelease version of this PR has been published! 🎉 To update
Or with npm:
|
No description provided.