Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alternarts): add archaeopteryx alternart #26

Merged
merged 2 commits into from
Feb 10, 2023
Merged

feat(alternarts): add archaeopteryx alternart #26

merged 2 commits into from
Feb 10, 2023

Conversation

MarcoDoC
Copy link
Contributor

@MarcoDoC MarcoDoC commented Feb 9, 2023 •
edited by airscripts
Loading

Pull Request

Label:

This PR is labeled as:

Choose only one and remember to select the label even on the right.

  • Feature
  • Bug
  • Other

Linked Issue

This PR has the following linked issues:

Solution

My solution is explained as follows:

Adds archaeopteryx alternart into alternarts folder.

@MarcoDoC MarcoDoC added the enhancement New feature or request label Feb 9, 2023
@MarcoDoC MarcoDoC added this to the 1.0.0 milestone Feb 9, 2023
@MarcoDoC MarcoDoC requested a review from airscripts February 9, 2023 18:58
@MarcoDoC MarcoDoC self-assigned this Feb 9, 2023
airscripts
airscripts requested changes Feb 10, 2023
View reviewed changes
Copy link
Member

@airscripts airscripts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to make this mergeable, remove the '-3' at the end of the filename.

@airscripts airscripts changed the title Added first alternart asset feat(alternart): add archaeopteryx alternart Feb 10, 2023
@airscripts
Copy link
Member

In order to make this mergeable, remove the '-3' at the end of the filename.

Lastly, make alternart folder name plural.

@airscripts airscripts changed the title feat(alternart): add archaeopteryx alternart feat(alternarts): add archaeopteryx alternart Feb 10, 2023
@MarcoDoC
Copy link
Contributor Author

both done

airscripts
airscripts approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@airscripts airscripts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@airscripts airscripts merged commit 6f45527 into main Feb 10, 2023
@airscripts airscripts deleted the collection-first-alternart-asset-#25 branch February 10, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airscripts airscripts airscripts approved these changes

Assignees

@MarcoDoC MarcoDoC

Labels
enhancement New feature or request
Projects
Dinos
Status: Done
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Release The First Alternart Asset
2 participants
@MarcoDoC @airscripts