fix: toggle oidc login via settings #4588
Conversation
- Keep state in settings ( like the other settings) - only check props once ( on system start ) - always include isOidcEnabled setting on settings request
...lgenis-emx2-graphql/src/main/java/org/molgenis/emx2/graphql/GraphqlDatabaseFieldFactory.java
Outdated
Show resolved
Hide resolved
backend/molgenis-emx2-sql/src/main/java/org/molgenis/emx2/sql/SqlDatabase.java
Show resolved
Hide resolved
...lgenis-emx2-graphql/src/main/java/org/molgenis/emx2/graphql/GraphqlDatabaseFieldFactory.java
Outdated
Show resolved
Hide resolved
| this.isOidcEnabled = Boolean.parseBoolean(isOidcEnabledSetting); | ||
| } else { | ||
| Object envSetting = | ||
| EnvironmentProperty.getParameter(Constants.MOLGENIS_OIDC_CLIENT_ID, null, STRING); |
There was a problem hiding this comment.
I think we should at some point have some way to find out about oidc errors but this is probably not the way.
| if (!this.isOidcEnabled) return; | ||
|
|
||
| // check if OIDC settings are complete otherwise log error and set to false | ||
| if (!isValidOidcSettings()) { |
There was a problem hiding this comment.
So we don't check if OIDC settings are complete, when enabled? This is fine by me, but I made it because it was requested
|
@mswertz @harmbrugge this is a cross service feature, i suggest to keep the setting part as simple ( and stateless ) as possible. The combination of oo programming, globals via statics and caching makes it hard to track the state. We can extend the ci setup to test the config code ( enabling and disabling the oidc login) ( other pr ) , a service check would need some polling ( e2e on prod setup ) per service instance , we do not have a setup for this. |
|
What are the main changes you did
Closes #4587
How to test
Checklist