Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fs support with drizzle and duckdb-wasm #30

Merged
merged 4 commits into from
Feb 22, 2025
Merged

feat: fs support with drizzle and duckdb-wasm #30

merged 4 commits into from
Feb 22, 2025

Conversation

sumimakito
Copy link
Collaborator

Summary

  • Integrate Origin Private FS and Node FS support in DuckDB WASM with DrizzleORM
  • Add DSN parser and builder helpers for duckdb-wasm://
  • Update playground
  • Add tests

Screenshot

localhost_5173_ (1)

Known issues

  • @duckdb/duckdb-wasm@1.29.1-dev68.0 is used as 1.29.0 fails to create empty DB files in OPFS
  • DB files are always created if missing, regardless of the value of accessMode in OPFS and Node FS (Will be fixed in the upstream)

@netlify Netlify
Copy link

netlify bot commented Feb 21, 2025 •
edited
Loading

✅ Deploy Preview for airi-vtuber ready!

Name Link
🔨 Latest commit 0d66178
🔍 Latest deploy log https://app.netlify.com/sites/airi-vtuber/deploys/67b9c820d03ba5000848ad67
😎 Deploy Preview https://deploy-preview-30--airi-vtuber.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Feb 21, 2025 •
edited
Loading

✅ Deploy Preview for drizzle-orm-duckdb-wasm ready!

Name Link
🔨 Latest commit 0d66178
🔍 Latest deploy log https://app.netlify.com/sites/drizzle-orm-duckdb-wasm/deploys/67b9c820db69600009d8e28e
😎 Deploy Preview https://deploy-preview-30--drizzle-orm-duckdb-wasm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sumimakito sumimakito marked this pull request as ready for review February 22, 2025 05:44
nekomeowww
nekomeowww reviewed Feb 22, 2025
View reviewed changes
Copy link
Member

@nekomeowww nekomeowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest is LGTM!

@nekomeowww nekomeowww added the enhancement New feature or request label Feb 22, 2025
@sumimakito sumimakito merged commit d985ade into main Feb 22, 2025
11 checks passed
@sumimakito sumimakito deleted the feat/drizzle-duck-fs branch February 22, 2025 12:56
@nekomeowww
Copy link
Member

Nicely, we can now work on the memory part.

nekomeowww pushed a commit that referenced this pull request Feb 22, 2025
@sumimakito @nekomeowww
feat: fs support with drizzle and duckdb-wasm (#30)
aeb17c7 
* feat: fs support with drizzle and duckdb-wasm

* docs: fix lint errors

* fix: apply suggestions

* fix: lockfile
@nekomeowww nekomeowww mentioned this pull request Mar 2, 2025
Open
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekomeowww nekomeowww nekomeowww left review comments

Assignees

@sumimakito sumimakito

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumimakito @nekomeowww