Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(binaryheader): account for optional fields in evt spd binary header #2234

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

mjreno
Copy link
Contributor

@mjreno mjreno commented Jun 14, 2024

Intended to address issue #2057.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 45.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 35.8%. Comparing base (18dfcb0) to head (5f680d7).
Report is 3 commits behind head on develop.

Current head 5f680d7 differs from pull request most recent head a01aa3e

Please upload reports for the commit a01aa3e to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #2234      +/-   ##
==========================================
- Coverage     73.5%   35.8%   -37.8%     
==========================================
  Files          294     294              
  Lines        58888   58901      +13     
==========================================
- Hits         43329   21122   -22207     
- Misses       15559   37779   +22220     
Files Coverage Δ
flopy/mf6/data/mffileaccess.py 64.3% <45.0%> (-10.9%) ⬇️

... and 201 files with indirect coverage changes

@mjreno mjreno marked this pull request as draft June 14, 2024 16:24
@mjreno mjreno changed the title fix(binaryheader): account for surf_rate_specified in evt spd binary header fix(binaryheader): account for optional fields in evt spd binary header Jun 14, 2024
@wpbonelli wpbonelli added the bug label Jun 19, 2024
@wpbonelli wpbonelli added this to the 3.9.1 milestone Nov 26, 2024
@wpbonelli wpbonelli modified the milestones: 3.9.1, 3.9.2 Jan 6, 2025
@wpbonelli wpbonelli modified the milestones: 3.9.2, 3.9.3 Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants