Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix optional dependency workflow #2089

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Feb 4, 2024

  • add some explanatory comments to optional.yml
  • check for shapely and scipy before creating voronoi test grids (fix failing optional.yml workflow)
  • run all non-regression, non-example tests in optional.yml — previously only smoke tests ran, but it's probably better to be comprehensive
  • fix test_modflow.py::test_pkg_data_containers
    • parametrized test IDs were not path-friendly on Windows, so could fail to create a temp dir named for the test case
    • the model could sometimes fail to converge, fix it

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86eb092) 73.0% compared to head (a5a3219) 71.2%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2089     +/-   ##
=========================================
- Coverage     73.0%   71.2%   -1.9%     
=========================================
  Files          259     259             
  Lines        59357   57980   -1377     
=========================================
- Hits         43352   41290   -2062     
- Misses       16005   16690    +685     

see 106 files with indirect coverage changes

@wpbonelli wpbonelli changed the title ci: fix optional dependency workflow, test against numpy nightly build ci: fix optional dependency workflow Feb 7, 2024
@wpbonelli wpbonelli merged commit 68228b4 into modflowpy:develop Feb 7, 2024
24 checks passed
@wpbonelli wpbonelli deleted the ci-tests branch February 7, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant