Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(GeoSpatialCollection): add support for GeoDataFrame objects #2063

Merged
merged 5 commits into from
Jan 26, 2024
Merged

update(GeoSpatialCollection): add support for GeoDataFrame objects #2063

merged 5 commits into from
Jan 26, 2024

Conversation

jlarsen-usgs
Copy link
Contributor

  • update test_geospatial_util.py to include GeoDataFrame tests
  • add geopandas as optional dependency

…objects

* update test_geospatial_util.py to include GeoDataFrame tests
* add geopandas as optional dependency
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (97da396) 73.0% compared to head (1d08926) 73.0%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2063     +/-   ##
=========================================
  Coverage     73.0%   73.0%             
=========================================
  Files          259     259             
  Lines        57887   59320   +1433     
=========================================
+ Hits         42263   43327   +1064     
- Misses       15624   15993    +369     
Files Coverage Δ
flopy/discretization/structuredgrid.py 47.6% <88.8%> (+0.4%) ⬆️
flopy/discretization/unstructuredgrid.py 85.4% <88.8%> (+<0.1%) ⬆️
flopy/discretization/vertexgrid.py 83.5% <88.8%> (+0.1%) ⬆️
flopy/discretization/grid.py 76.0% <77.7%> (-0.2%) ⬇️
flopy/utils/triangle.py 65.8% <60.0%> (+<0.1%) ⬆️
flopy/utils/geospatial_utils.py 92.8% <84.2%> (-1.0%) ⬇️

... and 73 files with indirect coverage changes

@jlarsen-usgs jlarsen-usgs merged commit f8eac0f into modflowpy:develop Jan 26, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant