Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SSE endpoint sessionId parameter handling #177

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve SSE endpoint sessionId parameter handling #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/server/sse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,17 @@ export class SSEServerTransport implements Transport {
});

// Send the endpoint event
/**
* Determine the appropriate separator for adding the sessionId parameter.
* Uses '&' if the endpoint already contains a query parameter (has a '?'),
* otherwise uses '?' to start the query string.
*
* Note: This approach works for standard endpoints but doesn't handle
* the edge case where '?' might be part of the path itself.
*/
const separator = this._endpoint.includes('?') ? '&' : '?';
this.res.write(
`event: endpoint\ndata: ${encodeURI(this._endpoint)}?sessionId=${this._sessionId}\n\n`,
`event: endpoint\ndata: ${encodeURI(this._endpoint)}${separator}sessionId=${this._sessionId}\n\n`,
);

this._sseResponse = this.res;
Expand Down