Fix MCP inspector connection with TypeScript SDK server #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes modelcontextprotocol#129 Update README.md to include instructions for running the server with the MCP inspector and update the quickstart example. * Add instructions for running the server with the MCP inspector. * Update the quickstart example to include the `StdioServerTransport` connection. * Add sections for Development Mode, Claude Desktop Integration, and Direct Execution. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/modelcontextprotocol/typescript-sdk/issues/129?shareId=XXXX-XXXX-XXXX-XXXX).
* **Running with MCP Inspector** - Add steps to install MCP Inspector globally using npm - Add steps to start the MCP server - Add steps to start the MCP Inspector and connect it to the running server
jspahrsummers
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Thank you for the PR! I've incorporated part of the change here into #136.
Unfortunately, the additions to "Running Your Server" seem to assume a particular package.json setup (e.g., dev and start scripts, dist/ directory), which the user might not have done.
If you want to document how to do those things, though, we could keep these as a follow-up. What are your thoughts?
tpina
reviewed
Jan 28, 2025
Comment on lines
+76
to
+77
| const transport = new StdioServerTransport(); | ||
| await server.connect(transport); |
There was a problem hiding this comment.
Suggested change
| const transport = new StdioServerTransport(); | |
| await server.connect(transport); | |
| async function main() { | |
| const transport = new StdioServerTransport(); | |
| await server.connect(transport); | |
| }; | |
| // invoke main method | |
| main().catch((error) => { | |
| console.error("Fatal error in main():", error); | |
| process.exit(1); | |
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129
Update README.md to include instructions for running the server with the MCP inspector and update the quickstart example.
StdioServerTransportconnection.For more details, open the Copilot Workspace session.