-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast fail feature - Stops verification process as soon as one failure is observed - Use case : CI speed up #3879
Merged
zhassan-aws
merged 12 commits into
model-checking:main
from
rajath-mk:fast-fail-feature
Feb 11, 2025
Merged
Fast fail feature - Stops verification process as soon as one failure is observed - Use case : CI speed up #3879
zhassan-aws
merged 12 commits into
model-checking:main
from
rajath-mk:fast-fail-feature
Feb 11, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity to check_all_harnesses function without flag --> draft commit.
…nly 4 harnesses are run (not in any specific order) but execution stops after that.
zhassan-aws
reviewed
Feb 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! Can you add another test that doesn't use --jobs
?
zhassan-aws
reviewed
Feb 10, 2025
Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
…into fast-fail-feature
zhassan-aws
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3458
Added the option
--fail-fast
, which would stop the verification process whenever any of the harnesses fails, and returns the failed harness as an error.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.