Skip to content

feat: Demostrate usage of the mod_cluster-bom artifact. + CI updates #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,23 @@ on:
pull_request:
branches:
- '*'
permissions:
contents: read
jobs:
ci:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ ubuntu-latest, windows-latest, macos-latest ]
java: [ 17 ]
os:
- macos-latest
- ubuntu-latest
- windows-latest
# Keep this list as: all supported LTS JDKs, the latest GA JDK, and optionally the latest EA JDK (if available).
# Reference: https://adoptium.net/support/
java:
- 17
- 21
- 24
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -23,4 +33,4 @@ jobs:
java-version: ${{ matrix.java }}
cache: maven
- name: Build with Maven
run: ./mvnw --batch-mode --no-transfer-progress verify
run: ./mvnw --batch-mode --no-transfer-progress clean verify
47 changes: 6 additions & 41 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,55 +42,20 @@
<maven.compiler.source>17</maven.compiler.source>

<!-- Dependency versions -->
<version.mod_cluster>2.0.4.Final</version.mod_cluster>
<version.org.jboss.mod_cluster>2.1.0.Final</version.org.jboss.mod_cluster>

<!-- Plugin versions -->
<version.org.wildfly.checkstyle-config>1.0.8.Final</version.org.wildfly.checkstyle-config>
</properties>

<dependencyManagement>
<dependencies>
<!-- mod_cluster -->
<!-- TODO replace with a BOM once available -->
<dependency>
<groupId>org.jboss.mod_cluster</groupId>
<artifactId>mod_cluster-container-spi</artifactId>
<version>${version.mod_cluster}</version>
</dependency>
<dependency>
<groupId>org.jboss.mod_cluster</groupId>
<artifactId>mod_cluster-container-tomcat-8.5</artifactId>
<version>${version.mod_cluster}</version>
</dependency>
<dependency>
<groupId>org.jboss.mod_cluster</groupId>
<artifactId>mod_cluster-container-tomcat-9.0</artifactId>
<version>${version.mod_cluster}</version>
</dependency>
<dependency>
<groupId>org.jboss.mod_cluster</groupId>
<artifactId>mod_cluster-core</artifactId>
<version>${version.mod_cluster}</version>
</dependency>
<dependency>
<groupId>org.jboss.mod_cluster</groupId>
<artifactId>mod_cluster-demo</artifactId>
<version>${version.mod_cluster}</version>
</dependency>
<dependency>
<groupId>org.jboss.mod_cluster</groupId>
<artifactId>mod_cluster-demo-client</artifactId>
<version>${version.mod_cluster}</version>
</dependency>
<dependency>
<groupId>org.jboss.mod_cluster</groupId>
<artifactId>mod_cluster-demo-server</artifactId>
<version>${version.mod_cluster}</version>
</dependency>
<dependency>
<groupId>org.jboss.mod_cluster</groupId>
<artifactId>mod_cluster-load-spi</artifactId>
<version>${version.mod_cluster}</version>
<artifactId>mod_cluster-bom</artifactId>
<version>${version.org.jboss.mod_cluster}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>
Expand All @@ -108,7 +73,7 @@
<failsOnError>true</failsOnError>
<includeTestSourceDirectory>true</includeTestSourceDirectory>
<excludes>**/*$logger.java,**/*$bundle.java</excludes>
<useFile />
<useFile/>
</configuration>
<dependencies>
<dependency>
Expand Down