Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support for something like a .modalignore? #2754

Open
MiroFurtado opened this issue Jan 13, 2025 · 2 comments
Open

[Feature Request] Support for something like a .modalignore? #2754

MiroFurtado opened this issue Jan 13, 2025 · 2 comments

Comments

@MiroFurtado
Copy link

MiroFurtado commented Jan 13, 2025

Hi! Modal seems like an awesome product that I've just started playing around with.

One thing I'm particularly interested in doing is using modal to just quickly spin up a GPU on a local working dir (ie. like modal launch jupyter --mount .) It'd be great if there was some way to exclude certain files from being mounted in the cli (ie. so I can ignore my .venv or something)

Also it would ideally be possible to pass secrets with modal launch.

@MiroFurtado MiroFurtado changed the title Support for something like a .modalignore? [Feature Request] Support for something like a .modalignore? Jan 13, 2025
@mwaskom
Copy link
Contributor

mwaskom commented Jan 13, 2025

Hi, thanks for your question. We probably aren't going to support a separate .modalignore file. It's possible that will change in the future, but we're somewhat philosophically committed to keeping as much configuration within the Python source files themselves rather than making behavior depend on the existence of other local files.

However we now support passing dockerignore-style patterns in a number of Image methods, e.g. Image.add_local_dir (docs). There's less of an obvious way to leverage that through the modal launch CLI, but note that modal launch is somewhat meant to provide a template that you could take and extend yourself if you need additional flexibility or features.

@MiroFurtado
Copy link
Author

Thank you! Makes sense, easy enough to do it programmatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants