Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When dropping files into a directory with spaces into its name, A duplicate directory with %20s is created #144

Open
zenhack opened this issue Jan 24, 2022 · 1 comment · May be fixed by #146

Comments

@zenhack
Copy link

zenhack commented Jan 24, 2022

Steps to reproduce:

  1. Create a new davros grain
  2. Create a directory with a space in its name, e.g. A Directory.
  3. Enter that directory.
  4. Drop some files into the directory.
  5. Go back up

There will then be two directories:

  • A Directory
  • A%20Directory

The files will be in the former; the latter will be empty.

@spollard
Copy link

I reproduced this bug and figured out a fix for it. Github is bothering me about 2 factor authentication and auth tokens yet again, so I just pushed my commit up to my sandstorm instead.

https://sandstorm.stephentpollard.com/shared/odh0IskHfMcEpYWRCG6mVOjGrWQ7i-fZGbUgvXDupxb

The fix, which is to decode the URI, could happen in app/components/davros-uploader.js (like I did), or app/models/files.js:ensureCollectionExists(), or even app/lib/ensure-collection-exists.js. I'm not sure where the best place is.

Perhaps I'll make a proper pull request if I can get github to let me push to my fork...

@spollard spollard linked a pull request Jul 22, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants