From b6614aab5410737899e577ade72eca6b3dc851e6 Mon Sep 17 00:00:00 2001 From: "Michael N. Lipp" Date: Mon, 29 Apr 2024 11:53:02 +0200 Subject: [PATCH] Fix codacy issues. --- .../org/jgrapes/io/util/ManagedBufferStreamer.java | 2 +- .../src/org/jgrapes/io/util/ThreadCleaner.java | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/org.jgrapes.io/src/org/jgrapes/io/util/ManagedBufferStreamer.java b/org.jgrapes.io/src/org/jgrapes/io/util/ManagedBufferStreamer.java index e85966f77cd..4ab5cf33251 100644 --- a/org.jgrapes.io/src/org/jgrapes/io/util/ManagedBufferStreamer.java +++ b/org.jgrapes.io/src/org/jgrapes/io/util/ManagedBufferStreamer.java @@ -34,7 +34,7 @@ */ public class ManagedBufferStreamer { - private ManagedBufferReader reader = new ManagedBufferReader(); + private final ManagedBufferReader reader = new ManagedBufferReader(); public ManagedBufferStreamer(Consumer processor) { Thread thread = new Thread(() -> { diff --git a/org.jgrapes.io/src/org/jgrapes/io/util/ThreadCleaner.java b/org.jgrapes.io/src/org/jgrapes/io/util/ThreadCleaner.java index 1d084916f51..f895ca14e2d 100644 --- a/org.jgrapes.io/src/org/jgrapes/io/util/ThreadCleaner.java +++ b/org.jgrapes.io/src/org/jgrapes/io/util/ThreadCleaner.java @@ -45,6 +45,10 @@ public class ThreadCleaner { private static ReferenceQueue abandoned = new ReferenceQueue<>(); + private ThreadCleaner() { + // Utility class + } + /** * Weak references to an object that interrupts the associated * thread if the object has been garbage collected. @@ -84,6 +88,13 @@ public RefWithThread(Object referent, Thread thread) { watchdog.start(); } + /** + * Watch the referent and terminate the thread if it is + * garbage collected. + * + * @param referent the referent + * @param thread the thread + */ public static void watch(Object referent, Thread thread) { watched.add(new RefWithThread(referent, thread)); }