Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported Extension to Firefox #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

tk-kushal
Copy link
Contributor

Changes:

  • Created a folder named Firefox ( for the Firefox version )
  • Modified progressbar.js ( added polyfill for window.requestAnimationFrame because the API is unavailable in Firefox)
  • Modified manifest.json ( rolled back to Manifest version 2 because of CORS issues and explicit permission issues, this is not an issue in Firefox as it is still properly supported, changed back from "host_permissions" to "permissions", added background page)
  • Created background.html to include all the Javascript files that will run in the background ( order of the import matters )
  • Modified background.js to remove importScripts() ( this is not supported in background pages in Firefox )

@mlsad3
Copy link
Owner

mlsad3 commented Jan 12, 2024

Thanks for figuring this all out :)

For the files that were not changed (images, amazonccc.js, amazonfs.js, etc), can you change to using symbolic links instead of just duplicating the files? That will really help with future maintenance. Thanks!

@tk-kushal
Copy link
Contributor Author

Thanks for figuring this all out :)

For the files that were not changed (images, amazonccc.js, amazonfs.js, etc), can you change to using symbolic links instead of just duplicating the files? That will really help with future maintenance. Thanks!

Yes, I can do that for the images and other assets but, it would be better to separate javascript as the APIs are different per browser so the separation is actually good in this case.

@tk-kushal
Copy link
Contributor Author

Replaced images with symbolic links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants