Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that CI fails on note/ warning #1235

Closed
sebffischer opened this issue Dec 20, 2024 · 1 comment
Closed

Ensure that CI fails on note/ warning #1235

sebffischer opened this issue Dec 20, 2024 · 1 comment

Comments

@sebffischer
Copy link
Member

For some reason, the CI currently passes although there are warnings in the tests.
There is already a PR to change this, but it does not seem to work: #1232

We should then also update the mlr-org rcmdcheck action: https://github.com/mlr-org/actions
@sebffischer
Copy link
Member Author

This error_on argument is just for the RCMD CHECK error/warning/note system so it's not clear to me how to achieve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebffischer