Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: global forms provider #250

Merged
merged 18 commits into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 96 additions & 0 deletions src/GlobalFormsProvider/GlobalFormsContext.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
import React, { useCallback, useContext, useMemo } from 'react';

export type FormInfo = { name: string; order: number };
type FormInfoMixed = string | FormInfo;
mic-web marked this conversation as resolved.
Show resolved Hide resolved

export type CallbackWithOrder = {
callback: () => Promise<void>;
order: number;
};

export type GlobalFormsContextType = {
isSubmitting: boolean;
reset: () => void;
setResetCallback: (form: FormInfo, callback: () => void) => void;
setSubmitCallback: (form: FormInfo, callback: () => Promise<void>) => void;
setSubmitting: (form: FormInfo, submitting: boolean) => void;
setSubmitSuccessful: (form: FormInfo, submitSuccessful: boolean) => void;
/**
* Returns a combined boolean of all submitSuccessful states
*/
mic-web marked this conversation as resolved.
Show resolved Hide resolved
submit: (additionalCallback?: CallbackWithOrder) => Promise<boolean>;
};

export const GlobalFormsContext = React.createContext<GlobalFormsContextType>({
isSubmitting: false,
reset: () => {},
setResetCallback: () => {},
setSubmitCallback: () => {},
setSubmitting: () => {},
setSubmitSuccessful: () => {},
submit: () => Promise.resolve(false),
});

export function useGlobalForms() {
const { isSubmitting, reset, submit } = useContext(GlobalFormsContext);

return {
isSubmitting,
reset,
submit,
};
}
mic-web marked this conversation as resolved.
Show resolved Hide resolved

export function normalizeFormInfo(form: FormInfoMixed): FormInfo {
if (typeof form === 'string') {
return { name: form, order: 0 };
}

return form;
}

export function useGlobalForm(form: FormInfoMixed) {
mic-web marked this conversation as resolved.
Show resolved Hide resolved
const formInfo = useMemo(() => normalizeFormInfo(form), [form]);

const {
setResetCallback,
setSubmitCallback,
setSubmitting,
setSubmitSuccessful,
} = useContext(GlobalFormsContext);

const setResetCallbackWrapped = useCallback(
spawnia marked this conversation as resolved.
Show resolved Hide resolved
(callback: () => void) => {
setResetCallback(formInfo, callback);
},
[formInfo, setResetCallback],
);

const setSubmitCallbackWrapped = useCallback(
(callback: () => Promise<void>) => {
setSubmitCallback(formInfo, callback);
},
[formInfo, setSubmitCallback],
);

const setSubmittingWrapped = useCallback(
(submitting: boolean) => {
setSubmitting(formInfo, submitting);
},
[formInfo, setSubmitting],
);

const setSubmitSuccessfulWrapped = useCallback(
(submitSuccessful: boolean) => {
setSubmitSuccessful(formInfo, submitSuccessful);
},
[formInfo, setSubmitSuccessful],
);

return {
setResetCallback: setResetCallbackWrapped,
setSubmitCallback: setSubmitCallbackWrapped,
setSubmitSuccessful: setSubmitSuccessfulWrapped,
setSubmitting: setSubmittingWrapped,
};
}
174 changes: 174 additions & 0 deletions src/GlobalFormsProvider/GlobalFormsProvider.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,174 @@
import { renderHook } from '@testing-library/react-hooks';
import React, { PropsWithChildren } from 'react';
import { act } from 'react-test-renderer';

Check failure on line 3 in src/GlobalFormsProvider/GlobalFormsProvider.test.tsx

View workflow job for this annotation

GitHub Actions / build

Cannot find module 'react-test-renderer' or its corresponding type declarations.

Check failure on line 3 in src/GlobalFormsProvider/GlobalFormsProvider.test.tsx

View workflow job for this annotation

GitHub Actions / typecheck

Cannot find module 'react-test-renderer' or its corresponding type declarations.
mic-web marked this conversation as resolved.
Show resolved Hide resolved

import { useGlobalForms, useGlobalForm } from './GlobalFormsContext';
import { GlobalFormsProvider } from './GlobalFormsProvider';

function createOptions() {
mic-web marked this conversation as resolved.
Show resolved Hide resolved
return {
wrapper: function Wrapper({ children }: PropsWithChildren<unknown>) {
return <GlobalFormsProvider>{children}</GlobalFormsProvider>;
},
};
}

describe('GlobalFormsProvider', () => {
it('finds one submitting form', () => {
const { result } = renderHook(() => {
const { isSubmitting } = useGlobalForms();
const { setSubmitting: setSubmitting1 } = useGlobalForm('form1');
const { setSubmitting: setSubmitting2 } = useGlobalForm('form2');

return { isSubmitting, setSubmitting1, setSubmitting2 };
}, createOptions());
expect(result.error).toBeFalsy();
expect(result.current.isSubmitting).toBeFalsy();

act(() => result.current.setSubmitting1(true));
act(() => result.current.setSubmitting2(false));
expect(result.current.isSubmitting).toBeTruthy();
});

it('overrides submitting value', () => {
const { result } = renderHook(() => {
const { isSubmitting } = useGlobalForms();
const { setSubmitting } = useGlobalForm('form');

return { isSubmitting, setSubmitting };
}, createOptions());
expect(result.current.isSubmitting).toBeFalsy();

act(() => result.current.setSubmitting(true));
expect(result.current.isSubmitting).toBeTruthy();

act(() => result.current.setSubmitting(false));
expect(result.current.isSubmitting).toBeFalsy();
});

it('calls all reset callbacks', () => {
const { result } = renderHook(() => {
const { reset } = useGlobalForms();
const { setResetCallback: setResetCallback1 } = useGlobalForm('form1');
const { setResetCallback: setResetCallback2 } = useGlobalForm('form2');

return { reset, setResetCallback1, setResetCallback2 };
}, createOptions());
result.current.reset();

const reset1 = jest.fn();
act(() => result.current.setResetCallback1(reset1));

const reset2 = jest.fn();
act(() => result.current.setResetCallback2(reset2));

result.current.reset();
expect(reset1).toHaveBeenCalledTimes(1);
expect(reset2).toHaveBeenCalledTimes(1);

act(() => result.current.setResetCallback1(jest.fn()));
result.current.reset();
expect(reset1).toHaveBeenCalledTimes(1);
expect(reset2).toHaveBeenCalledTimes(2);
});

it('overrides reset callback', () => {
const { result } = renderHook(() => {
const { reset } = useGlobalForms();
const { setResetCallback } = useGlobalForm('form');

return { reset, setResetCallback };
}, createOptions());
const resetOld = jest.fn();
act(() => result.current.setResetCallback(resetOld));
result.current.reset();
expect(resetOld).toHaveBeenCalledTimes(1);

const resetNew = jest.fn();
act(() => result.current.setResetCallback(resetNew));
result.current.reset();
expect(resetOld).toHaveBeenCalledTimes(1);
expect(resetNew).toHaveBeenCalledTimes(1);
});

it('calls all submit callbacks', async () => {
const { result } = renderHook(() => {
const { submit } = useGlobalForms();
const { setSubmitCallback: setSubmitCallback1 } = useGlobalForm('form1');
const { setSubmitCallback: setSubmitCallback2 } = useGlobalForm('form2');

return { submit, setSubmitCallback1, setSubmitCallback2 };
}, createOptions());
await expect(result.current.submit()).resolves.toBeTruthy();

const submit1 = jest.fn(() => Promise.resolve());
act(() => result.current.setSubmitCallback1(submit1));

const submit2 = jest.fn(() => Promise.resolve());
act(() => result.current.setSubmitCallback2(submit2));

await expect(result.current.submit()).resolves.toBeFalsy();
expect(submit1).toHaveBeenCalledTimes(1);
expect(submit2).toHaveBeenCalledTimes(1);
});

it('overrides submit callback', async () => {
const { result } = renderHook(() => {
const { submit } = useGlobalForms();
const { setSubmitCallback } = useGlobalForm('form');

return { submit, setSubmitCallback };
}, createOptions());

const submitOld = jest.fn(() => Promise.resolve());
act(() => result.current.setSubmitCallback(submitOld));

await expect(result.current.submit()).resolves.toBeFalsy();
expect(submitOld).toHaveBeenCalledTimes(1);

const submitNew = jest.fn(() => Promise.resolve());
act(() => result.current.setSubmitCallback(submitNew));

await expect(result.current.submit()).resolves.toBeFalsy();
expect(submitOld).toHaveBeenCalledTimes(1);
expect(submitNew).toHaveBeenCalledTimes(1);
});

it('maintains submit order', async () => {
const { result } = renderHook(() => {
const { submit } = useGlobalForms();
const { setSubmitCallback: setSubmitCallbackError } = useGlobalForm({
name: 'form-error',
order: 2,
});
const { setSubmitCallback: setSubmitCallbackFirst } = useGlobalForm({
name: 'form-first',
order: 1,
});
const { setSubmitCallback: setSubmitCallbackLast } = useGlobalForm({
name: 'form-last',
order: 3,
});

return {
submit,
setSubmitCallbackError,
setSubmitCallbackFirst,
setSubmitCallbackLast,
};
}, createOptions());
const submitError = jest.fn(() => Promise.reject());
act(() => result.current.setSubmitCallbackError(submitError));

const submitFirst = jest.fn(() => Promise.resolve());
act(() => result.current.setSubmitCallbackFirst(submitFirst));

const submitLast = jest.fn(() => Promise.resolve());
act(() => result.current.setSubmitCallbackLast(submitLast));

await expect(result.current.submit()).rejects.toBeFalsy();
expect(submitFirst).toHaveBeenCalledTimes(1);
expect(submitError).toHaveBeenCalledTimes(1);
expect(submitLast).toHaveBeenCalledTimes(0);
mic-web marked this conversation as resolved.
Show resolved Hide resolved
});
});
Loading
Loading