Build suggesters "manually" against each solr replica #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were dealing with some instabilities in the k8s cluster in 2024.09 when we wanted
to release this, resulting nodes loosing track of zookeeper and suggesters not getting
built (calls would time out). Attempt to brute-force this by hitting the individual
solr URLs directly, taking advantage of knowledge about how many replicas and what
they're called that we'd really rather not have to know.
NOTE: Once it's determined we don't need this hack, tear the relevant code in
MedInstaller:IndexingSteps#index (after the second call to @build_collection.commit),
leaving only a single `rebuild_suggesters` and call it a day.
To run in once for each configured solr replica, we need the following:
* ENV[DIRECT_URLS_TO_SOLR_REPLICAS]: A space-delimited set of urls of the form
"http://solr-solrcloud-1:8083" or whatever. This is the same format as the
generic (cluster-level) connection string found in ENV[SOLR_URL] (e.g., no trailing "solr")
* A non-falsey value for ENV[MANUALLY_BUILD_SUGGESTERS] to enable it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were dealing with some instabilities in the k8s cluster in 2024.09 when we wanted to release this, resulting nodes loosing track of zookeeper and suggesters not getting built (calls would time out). Attempt to brute-force this by hitting the individual solr URLs directly, taking advantage of knowledge about how many replicas and what they're called that we'd really rather not have to know.
NOTE: Once it's determined we don't need this hack, tear the relevant code in MedInstaller:IndexingSteps#index (after the second call to @build_collection.commit), leaving only a single
rebuild_suggestersand call it a day.To run in once for each configured solr replica, we need the following: