ensure point_interval(<distribution>) supports tidy eval, closes #221

mjskay · Apr 6, 2024 · 6d1e113 · 6d1e113
1 parent e50c83a
commit 6d1e113
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/R/point_interval.R b/R/point_interval.R
@@ -349,10 +349,12 @@ point_interval.rvar = function(
   .width = .95, .point = median, .interval = qi, .simple_names = TRUE, na.rm = FALSE
 ) {
   x = .data
-  # using substitute here so that names of .point / .interval are passed down correctly
-  eval(substitute(point_interval(
+  # using eval_tidy here so that names of .point / .interval are passed down correctly
+  eval_tidy(expr(point_interval(
     tibble(.value = x), ...,
-    .width = .width, .point = .point, .interval = .interval, .simple_names = .simple_names, na.rm = na.rm
+    .width = .width,
+    .point = {{ .point }}, .interval = {{ .interval }},
+    .simple_names = .simple_names, na.rm = na.rm
   )))
 }
 

diff --git a/tests/testthat/test.point_interval.R b/tests/testthat/test.point_interval.R
@@ -734,6 +734,13 @@ test_that("flattened indices retain index order", {
 
 })
 
+test_that("automatic partial evaluation works with distributional objects", {
+  expect_equal(
+    point_interval(.point = mean)(dist_normal()),
+    point_interval(dist_normal(), .point = mean)
+  )
+})
+
 
 # 100% intervals ----------------------------------------------------------