Skip to content

Commit

Permalink
point_interval(<tibble>) always returns a tibble, closes #224
Browse files Browse the repository at this point in the history
  • Loading branch information
mjskay committed Apr 6, 2024
1 parent 0c4ac78 commit 1128fae
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 2 deletions.
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ S3method(point_interval,default)
S3method(point_interval,distribution)
S3method(point_interval,numeric)
S3method(point_interval,rvar)
S3method(point_interval,tbl_df)
S3method(print,ggdist_partial_function)
S3method(quantile,ggdist__weighted_sample)
S3method(quantile,ggdist__wrapped_categorical)
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Bug fixes:

* Ensure `point_interval(<distribution>)` supports tidy evaluation on the
`.point` and `.interval` arguments (#221).
* `point_interval(<tibble>)` always returns a `tibble()` (#224).


# ggdist 3.3.2
Expand Down
19 changes: 17 additions & 2 deletions R/point_interval.R
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,16 @@ point_interval = function(

#' @rdname point_interval
#' @export
point_interval.default = function(.data, ..., .width = .95, .point = median, .interval = qi, .simple_names = TRUE,
na.rm = FALSE, .exclude = c(".chain", ".iteration", ".draw", ".row"), .prob
point_interval.default = function(
.data,
...,
.width = .95,
.point = median,
.interval = qi,
.simple_names = TRUE,
na.rm = FALSE,
.exclude = c(".chain", ".iteration", ".draw", ".row"),
.prob
) {
.width = .Deprecated_argument_alias(.width, .prob)
data = .data # to avoid conflicts with tidy eval's `.data` pronoun
Expand Down Expand Up @@ -312,6 +320,12 @@ point_interval.default = function(.data, ..., .width = .95, .point = median, .in
result
}

#' @rdname point_interval
#' @export
point_interval.tbl_df = function(.data, ...) {
as_tibble(NextMethod(), .name_repair = "minimal")
}

#' @rdname point_interval
#' @export
point_interval.numeric = function(.data, ..., .width = .95, .point = median, .interval = qi, .simple_names = FALSE,
Expand Down Expand Up @@ -343,6 +357,7 @@ point_interval.numeric = function(.data, ..., .width = .95, .point = median, .in
}

#' @rdname point_interval
#' @importFrom rlang eval_tidy expr
#' @export
point_interval.rvar = function(
.data, ...,
Expand Down
3 changes: 3 additions & 0 deletions man/point_interval.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1128fae

Please sign in to comment.