Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #3 by trimming beginning and trailing whitespace in cell content #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixes #3 by trimming beginning and trailing whitespace in cell content #6

wants to merge 1 commit into from

Conversation

NogsMPLS
Copy link

No description provided.

@NogsMPLS NogsMPLS changed the title fixes #4 by trimming beginning and trailing whitespace in cell content fixes #3 by trimming beginning and trailing whitespace in cell content Mar 22, 2018
@NogsMPLS
Copy link
Author

Actually fixes #3, lol, typo'd the commit message.

@laurent22
Copy link

laurent22 commented May 17, 2018 •
edited
Loading

That wouldn't fix it if the new lines are inside the cell content though. In my opinion, the cell content should simply go through content.replace(/\n+/g, "<br>") which will renders correctly in most Markdown renderers, and will also allow having new lines inside table cells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NogsMPLS @laurent22