Conditionally force MD for tables without THEAD #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rDuckDev
changed the title
rDuckDev
changed the title
rDuckDev
changed the title
|
Hey @domchristie, any chance this could get merged? Thanks! |
|
@krystof-k, if that can be of any help, I've implement this and other features in my fork: https://github.com/laurent22/joplin-turndown Note that those are meant to support the Joplin web clipper but it could also work for you depending on your use case (the full list of changes for each fork is at the top of the readme). I assume that @domchristie's code is more general purpose. |
|
@laurent22 cool, I'll try it. Thanks! |
|
They both got a npm package by the way: |
|
So what is the status of this PR? Should I just go ahead and use joplin-turndown-plugin-gfm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revision of pull request #10 by @laurent22.
I agree that the desired behavior is application-dependent; however, @oliverguenther raises a valid argument that using GitHub's default implementation is much more clear.
P.S. - sorry for the duplication of #10 and (my failed attempt with) #15.