Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use submissions app #16

Closed
tssheth opened this issue Jul 11, 2014 · 4 comments
Closed

Refactor to use submissions app #16

tssheth opened this issue Jul 11, 2014 · 4 comments
Assignees
Labels

Comments

@tssheth
Copy link

tssheth commented Jul 11, 2014

See https://github.com/edx/edx-submissions and the corresponding post on the edx-code mailing list: https://groups.google.com/forum/#!searchin/edx-code/submission/edx-code/YrcP2770L3I/wqGkbpN7noQJ

Using submissions will avoid the current requirement that students re-visit the SGA problem in order to have their grade recorded.

(See jazkarta#21)

@tssheth tssheth added the P3 label Jul 11, 2014
@chrisrossi
Copy link

I've just pushed a first pass of this to the 'submissions' branch. It was a bit more invasive than probably any of us realized it would be. Almost all of the Python code was touched in some way or another.

We still have the requirement of accessing the StudentModule models directly in order to serialize and deserialize the the student state, since there was still a lot of student state we couldn't move into the submissions app: staff annotated file upload, instructor comments, workflow related fields.

It does achieve the objective, though, of allowing a score to be published immediately without any strange workarounds.

I still need to update tests.

@chrisrossi
Copy link

Tests are updated.

@pdpinch pdpinch added this to the Fall Residential milestone Aug 11, 2014
@pdpinch pdpinch self-assigned this Aug 12, 2014
@chrisrossi
Copy link

Hi, what's the prospect for merging the 'submissions' branch? I think I was waiting for some feedback that I never got, and I see work has continued on 'master' in the meantime. This is a pretty big refactor so we don't want to let it get too far behind, unless we think we don't want to merge it.

@pdpinch
Copy link
Member

pdpinch commented Jan 8, 2015

This will be addressed in the 0.4.0 release

@pdpinch pdpinch closed this as completed Jan 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants