Fix peerDependency from ember-source
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RobbieTheWagner thanks for merging everything... do you have any plan, what we should do as next? Is there any roadmap to next major, what we should do? Or do you think that we have now everything? Edit: in code i have seen that normalize.ts should be privat... i will add minimal fixes to this PR in next days |
RobbieTheWagner
approved these changes
Jun 1, 2024
|
@mkszepp no plans, I think updating all this is probably all we need. |
|
@RobbieTheWagner okay that sound good... the only thing what i would like to do, before we are making the release is, exporting the normalize util private. I will look to make a PR in next days |
|
Sounds good @mkszepp! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have forgot to update the peerDependency in
package.json