Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With recent ember-cli development, the resolver modifications no longer seem to be necessary #71

Open
begedin opened this issue Dec 4, 2017 · 1 comment

Comments

@begedin
Copy link

begedin commented Dec 4, 2017

As of ember-cli 2.17.0, the test-helper module no longer uses the custom tests/helpers/resolver.js and instead defaults to the app/resolver.js. Basically, the whole tests/helpers/resolver.js file is removed completely.

With it gone, and the app resolver being used, it looks like the fix for pluralized ability: 'abilities' is no longer necessary, so we should be able to safely remove it, unless I'm mistaken.

@jamesarosen
Copy link

jamesarosen commented Feb 7, 2018

I think it's only fixed if initializer:ember-can is required. You don't have to run the initializer since the relevant resolver modifications are in the module, not the initializer it exports. That means that if an acceptance test runs first, it'll work. If a unit or integration test runs first, however, there could be problems.

The blueprint should at minimum add

// tests/test-helper.js

import '{{appName}}/initializers/ember-can'

Perhaps better would be to create something like

// addon/utils/initialize-resolver.js
export default function() {
  // do stuff to resolver
}

and then import and run that from app/initializers/ember-can and from tests/test-helper.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants