Upgrade Dependencies to Resolve FCW Warnings #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building this project started to emit future compatibility warnings. We resolve this by upgrading wasm-bindgen to at least 0.2.89. Unfortunately upstream seed 0.6.0 is incompatible with that and upgrading that is way too messy, so replace that package with a fork that just has the necessary patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building this project started to emit future compatibility warnings. It appears to be related to these issues (rust-lang/rust#79813, rust-lang/rust#71871). We resolve this by upgrading wasm-bindgen to at least 0.2.89.
Unfortunately, upstream seed 0.6.0 is incompatible with that and upgrading seed is way too messy, so replace that package with a fork that just has the necessary patch. If there are security concerns with using my fork, this can be changed to a fork of your own, which can be replicated by checking out the upstream seed's 0.6.0 tag and cherry-picking this commit.