Support Rails 8.0 #259
Closed
Support Rails 8.0 #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somebody to merge it? Thanks :) |
|
ping @blowmage |
zenspider
reviewed
Nov 27, 2024
There was a problem hiding this comment.
OK. I'mma step in and try to maintain this for a while... As such I'm still catching up... I've asked for some changes to #255 and going to tend to that before the 8.0 PRs... as such I suspect it'll cause conflict on your branch when it gets finalized and merged.
|
Please rebase and fix conflicts OR tell me you're letting this go and I can try to take it over |
n-rodriguez
force-pushed
the
wip/rails8
branch
from
af10d27 to
fbef814
Compare
|
@zenspider done! |
n-rodriguez
force-pushed
the
wip/rails8
branch
from
fbef814 to
4f70126
Compare
|
I went with #258 as it covered changing all the URLs in the rdoc. If you rebase and fix conflicts I can see about merging any differences you still have. |
|
@zenspider I'm fine with #258. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you!