enable get credentials from environment

[dormanze]

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

If the AK or SK contains special characters, using the environment variable prefixed with MC_HOST_ to preset aliases fails.

Motivation and Context

Presetting aliases using environment variables no need to worry about special characters.

How to test this PR?

before:

export MC_HOST_test=https://test1:a:b:c:@ASDASDSAD@play.min.io
mc ls test

afrer:

export access_key=test1
export secret_key=a:b:c:@ASDASDSAD
export MC_HOST_test=https://access_key:secret_key@play.min.io
mc ls test --creds-env

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Optimization (provides speedup with no functional changes)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• Fixes a regression (If yes, please add commit-id or PR # here)
• Unit tests added/updated
• Internal documentation updated
• Create a documentation update request here

[harshavardhana]

this is become way too much @dormanze we cannot keep adding cockpit options into mc

I do understand that you may want : in your access key, but that is certainly not something we can support.

What we do today is far more sufficient and has no reason to add credentials with : in them - it doesn't add any value

[dormanze]

this is become way too much @dormanze we cannot keep adding cockpit options into mc

I do understand that you may want : in your access key, but that is certainly not something we can support.

What we do today is far more sufficient and has no reason to add credentials with : in them - it doesn't add any value

The Minio server does not restrict special characters. In addition, the mc admin accesskey does not restrict special characters. Do you think we should add the verification on special characters? In addition, the document needs to describe the types of special characters that we do not support.