Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realign Content Resolver workloads post Dev/QE merger #1332

Merged

Conversation

nielsdg
Copy link
Contributor

@nielsdg nielsdg commented Nov 28, 2024

Some components got shuffled around, so it makes sense that we also align the content workloads with the new org structure.

For the unwanted packages, splitting this up over the multiple SSTs was a bit harder since they contains for example some very historical dependencies of e.g. Xorg or some multimedia libraries. I tried to move those the most appropriate SST where possible.

@tpelka83
Copy link
Contributor

LGTM to me.

@Jiri-Koten
Copy link
Contributor

LGTM

Comment on lines +24 to +25
# Seems unused
- libsamplerate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually unwanted? It is a dependency of alsa-plugins and alsa-utils, and has been in each RHEL release since at least 6.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, this just moves it from the unwanted sst_gpu packages to the sst_display_hardware_multimedia unwanted packages. It's been there for a pretty long time now, so I'll leave it to @Jiri-Koten and @tpelka83 to figure that out. I don't have a strong opinion either way :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote for keeping it unwanted.

Comment on lines +28 to +30
# Removed in favor of pipewire(-pulse). Note that the SRPM with the same
# name should still be built for some packages, like pulseaudio-libs
- pulseaudio
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I know. It was already part of sst_gpu-unwanted.yml, so I guess this could be in a follow-up MR once those are resolved?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should definitely remain here unwanted, but even better if we don't build it all.

configs/sst_gpu-unwanted.yaml Show resolved Hide resolved
Some components got shuffled around, so it makes sense that we also
align the content workloads with the new org structure.

For the unwanted packages, splitting this up over the multiple SSTs was
a bit harder since they contains for example some very historical
dependencies of e.g. Xorg or some multimedia libraries. I tried to move
those the most appropriate SST where possible.
@yselkowitz yselkowitz force-pushed the gpu-split-up-post-dev-qe-merger branch from f965095 to cd5ddb1 Compare December 3, 2024 20:43
@yselkowitz yselkowitz merged commit 1c82cf7 into minimization:main Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants