-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Realign Content Resolver workloads post Dev/QE merger #1332
Realign Content Resolver workloads post Dev/QE merger #1332
Conversation
LGTM to me. |
LGTM |
# Seems unused | ||
- libsamplerate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually unwanted? It is a dependency of alsa-plugins and alsa-utils, and has been in each RHEL release since at least 6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, this just moves it from the unwanted sst_gpu packages to the sst_display_hardware_multimedia unwanted packages. It's been there for a pretty long time now, so I'll leave it to @Jiri-Koten and @tpelka83 to figure that out. I don't have a strong opinion either way :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote for keeping it unwanted.
# Removed in favor of pipewire(-pulse). Note that the SRPM with the same | ||
# name should still be built for some packages, like pulseaudio-libs | ||
- pulseaudio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I know. It was already part of sst_gpu-unwanted.yml, so I guess this could be in a follow-up MR once those are resolved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should definitely remain here unwanted, but even better if we don't build it all.
Some components got shuffled around, so it makes sense that we also align the content workloads with the new org structure. For the unwanted packages, splitting this up over the multiple SSTs was a bit harder since they contains for example some very historical dependencies of e.g. Xorg or some multimedia libraries. I tried to move those the most appropriate SST where possible.
f965095
to
cd5ddb1
Compare
Some components got shuffled around, so it makes sense that we also align the content workloads with the new org structure.
For the unwanted packages, splitting this up over the multiple SSTs was a bit harder since they contains for example some very historical dependencies of e.g. Xorg or some multimedia libraries. I tried to move those the most appropriate SST where possible.