org-modern todo stopped working on custom agenda views

[cpence]

Sorry for what is a strangely vague bug report, but I recently updated my package repositories and the new version of org-modern that I installed seems to no longer support custom agenda views (i.e., org-agenda-custom-commands).

I've done a bit of digging, and it seems like in these views, org-todo-keywords-for-agenda is actually nil, as is org-todo-keywords-1, so org-modern doesn't know what it's supposed to prettify. I have no idea why this would have happened. I've checked and the behavior reproduces both for global-org-modern-mode and if org-modern-agenda is part of the finalize-hook.

Any ideas what might have gone wrong or how I could help debug further?

[minad]

Can you reproduce the problem with emacs -Q?

[minad]

Ah. Thanks I see. This is actually an upstream bug, where org-todo-keywords-for-agenda is incorrectly set to nil. Iirc this had been fixed at some point. Maybe there is a regression? Please report it upstream on the Org issue tracker.

[cpence]

From upstream:

Thanks for reporting!

Please note that `org-todo-keywords-for-agenda' is a global variable
that is accumulating todo keywords in all the files contributing to
current agenda block. It is not guaranteed to contain all the keywords
in current agenda buffer - the value is cleaned every time a new agenda
block is computed, and can only be relied upon immediately after
building a single agenda block, not even multiple blocks.

Agenda stores information about todo keywords in the text properties for
each individual entry - see 'org-todo-regexp and 'org-not-done-regexp
text properties, which contain specific regexps to match todo/done
keywords specific to the buffer each agenda entry is coming from
(remember that keywords may or may not be the same in different buffers,
and that some keyword in one buffer may not be a keyword in another buffer).

Not a bug.
Canceled.

[minad]

Okay, we should then use the org-todo-regexp and org-not-done regexps I guess. Patches welcome.

[minad]

Fixed in 6550abc