Fix invalid Java unit test assertion #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallman
commented
May 12, 2024
|
|
||
| import static org.junit.Assert.*; | ||
|
|
||
| /** | ||
| * Unit tests for CodeCompletionCore | ||
| */ | ||
| @FixMethodOrder(MethodSorters.NAME_ASCENDING) |
There was a problem hiding this comment.
This annotation was hiding the broken test. Test correctness shouldn't depend on the order in which the test methods are run.
mallman
commented
May 12, 2024
| @@ -153,8 +150,8 @@ public void test2_typicalExpressionTest() throws Exception { | |||
| assertTrue(candidates.tokens.containsKey(ExprLexer.VAR)); | |||
| assertTrue(candidates.tokens.containsKey(ExprLexer.LET)); | |||
|
|
|||
| assertEquals(Arrays.asList(new Integer[]{ExprLexer.ID, ExprLexer.EQUAL}), candidates.tokens.get(ExprLexer.VAR)); | |||
There was a problem hiding this comment.
ExprLexer.ID and ExprLexer.EQUAL are members of the ignored token set, so they should not be candidate completions.
mike-lischke
approved these changes
May 13, 2024
|
Thanks @mallman, please sign your patch so I can merge it (see the DCO link) |
tokens as completions Signed-off-by: Michael Allman <msa@allman.ms>
Done. Any thoughts on how to fix the associated bug? Do you want to take that on yourself? |
|
No idea yet. If you would like to take that over that would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix invalid Java unit test assertion. C3 should not suggest ignored tokens as completions.
See issue #77 for related discussion.
This invalid assertion was hiding a bug in C3. How to fix that bug is up for discussion, but basically it appears that the implementation of the
followSetsByATNglobal cache is problematic. This cache is based on the class name of the parser object, but it does not account for ignored tokens. Two instances ofCodeCompletionCorewill use the samefollowSetsByATNentry for the same parser, even if they have different ignored tokens. How to fix this?The other language implementations of C3 may have the same problem. For example, it looks to me like the C# tests have the same invalid assertion. I'm not sure I want to touch that, though, because I'm not familiar with C#. So this PR just addresses the Java port.
I'm also wondering if this is related to #66 as well. @mike-lischke is the expert here.